Enabled no-console eslint rule + error instead of warning#585
Merged
Conversation
Contributor
|
Don't we have legitimate uses of console.log in the code that need to be exempted by an |
Contributor
Author
Yes. It's just that I like breaking tests and then fixing them in separate commits. |
Contributor
|
Sorry, I guess I jumped the gun once I saw the PR. I'll wait until it's out of draft! |
benesjan
force-pushed
the
janb/no-console-log
branch
from
e1598c5 to
0f7f491
Compare
benesjan
changed the title
spypsy
reviewed
May 17, 2023
| const end1 = new Date().getTime() - start1; | ||
| // const end1 = new Date().getTime() - start1; | ||
|
|
||
| console.log(`Single hasher: ~${end1 / values.length}ms / value`); |
Contributor
Author
There was a problem hiding this comment.
Hello, I think here it's ok to leave the console.log statements commented out because it's just for when people run it locally + the whole test is a messy WIP.
spypsy
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #446 + more strict eslint rules
Checklist: